Evaluate markers under environment with empty "extra" #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMino
force-pushed
the
empty-extras-are-default
branch
3 times, most recently
from
d4b6dea
to
cda2a0a
Compare
MrMino
force-pushed
the
empty-extras-are-default
branch
from
cda2a0a
to
b94b8e7
Compare
MrMino
force-pushed
the
empty-extras-are-default
branch
from
fe7d54f
to
21d6058
Compare
uranusjr
reviewed
May 18, 2022
sbidoul
reviewed
Jun 4, 2022
| @@ -110,6 +109,7 @@ def test_matches_expected(self): | |||
| ) | |||
|
|
|||
| assert environment == { | |||
| "extra": "", | |||
There was a problem hiding this comment.
Since default_environment is part of the public API (pending documentation #503), I wonder if we should avoid adding extra to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #548.
This required removing code that raised
UndefinedEnvironmentNameexception (see comment). The class declaration has been left as to not introduce a breaking change in the interface.